Acquire client lock in heartbeat thread before sending requests #2620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
lookup_coordinator
and_send_heartbeat_request
make client api calls that require locking. The tricky part of the heartbeat run loop is that we need to always acquire client lock first and coordinator lock second (to avoid deadlocks), but we also cannot hold the client lock while calling coordinator lock.wait() . To make this easier, switch from context managers to try / finally and catch any RuntimeError if the client lock has already been released when we reach the finally block.